RDKB-64839 Fix memory leaks in bus_insert_elem_node on duplicate elem…#1142
Merged
Conversation
…ent insertion Reason for change: Memory leak in onewifi process Test Procedure: Debug Priority: P1 Risks: Low Signed-off-by: Petro Krynytskyi <petr0krynytskiy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory leak in bus_insert_elem_node() when inserting an element whose node already exists (duplicate insert), improving stability of the onewifi process.
Changes:
- Free previously allocated
current_node->node_elem_databefore overwriting it on re-insert to prevent leaks. - Avoid creating a new table row template (
{i}) when a table node already has a child, preventing child-node leaks/overwrites on duplicate inserts. - Add cleanup for
node_elem_datawhen table row-template allocation fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
narendradandu
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent insertion
Reason for change: Memory leak in onewifi process
Test Procedure: Debug
Priority: P1
Risks: Low